Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): add fallback for currentVersionResolver in the version step #21155

Merged

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jan 16, 2024

Current Behavior

nx release version fails when currentVersionResolver is 'git-tag' or 'registry' and a new independent package or release group is created.

Expected Behavior

nx release version provides a way to use 'disk' as the fallback when the currentVersionResolver of 'git-tag' or 'registry' isn't available. This is opt-in, and it will allow for versioning within CI.

Related Issue(s)

Fixes #
#19971

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 0:11am

@fahslaj fahslaj force-pushed the feat/fallback-current-version-resolver branch from a23c665 to 8a66733 Compare January 16, 2024 07:04
@fahslaj fahslaj marked this pull request as ready for review January 16, 2024 07:25
@fahslaj fahslaj requested review from a team as code owners January 16, 2024 07:25
@JamesHenry JamesHenry merged commit 8f2dee0 into nrwl:master Jan 17, 2024
6 checks passed
@fahslaj fahslaj deleted the feat/fallback-current-version-resolver branch January 17, 2024 14:31
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants