cleanup(misc): clean up init generators

[leosvelperez]

This PR simplifies the tasks performed by init generator in the following way:

• Remove calls to other init generators
• Install the minimum required dependencies needed for the plugin to work
  • Most dependencies are only needed and can be installed by the generators invoking the init generators
• Configure the minimum required for the plugin to work
  • Most configuration changes are only needed and can be done by the generators invoking the init generators

The init generators were always internal and meant to be called by other generators to ensure the base dependencies and configuration were set up. This is changing. While they'll continue to be internal, soon they could also be invoked when running nx add and nx init. In those scenarios, we only need to initialize the minimum required for the plugin to work. We wouldn't be generating anything just yet and can't make assumptions and install/configure things that might not be needed by the workspace.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Jan 15, 2024 2:29pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 09785ce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=9747eead55ec000dc8ecf45aba491d439cf65b93 --head=09785ce3979d306ca661f70b4091e77ee2ae20fe --parallel=1
• nx affected --targets=lint,test,build --base=9747eead55ec000dc8ecf45aba491d439cf65b93 --head=09785ce3979d306ca661f70b4091e77ee2ae20fe --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=9747eead55ec000dc8ecf45aba491d439cf65b93 --head=09785ce3979d306ca661f70b4091e77ee2ae20fe
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=9747eead55ec000dc8ecf45aba491d439cf65b93 --head=09785ce3979d306ca661f70b4091e77ee2ae20fe

---

Sent with 💌 from NxCloud.

[mandarini]

Just two small comments. I'm testing this out locally and then I'll approve.

[mandarini]

Tested it locally:

• generate new workspace
• add react app
• add vue app
• add nuxt app
• add storybook

All works as expected.

[jaysoo]

Added a question, the rest LGTM.

[meeroslav]

If the purpose of removing this dependency before re-adding it was to avoid version clash if the same package is installed in dependencies and devDependencies then wouldn't we want to do the same with the other packages listed below - eslint, @nx/eslint-plugin, @typescript-eslint/*?

[jaysoo]

No, there's follow-up work to use the updated addDependenciesToPackageJson, the util PR is pending merge: #21123

[leosvelperez]

I assume that was the reason, but I'm unsure. I just left the existing behavior for this. IMHO, we shouldn't do it for any. AFAIK, the addDependenciesToPackageJson function handles this though maybe differently. I haven't checked.

[meeroslav]

Left one minor comment but otherwise looks good to me.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.