Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use argument length that match the actual size of the argument length #21074

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

rluvaton
Copy link
Contributor

Current Behavior

Getting an argument list is too big (E2BIG) in format:check

Expected Behavior

to not fail due to argument list is too big

Related Issue(s)

@rluvaton rluvaton requested a review from a team as a code owner January 10, 2024 13:43
@rluvaton rluvaton requested a review from FrozenPandaz January 10, 2024 13:43
Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 3:00pm

@rluvaton
Copy link
Contributor Author

I have no idea why the CI failed for Linux, and the macOS is something in CircleCI

@AgentEnder AgentEnder force-pushed the fix-args-length-not-correct branch from f1e520d to d33056f Compare July 24, 2024 14:49
@AgentEnder AgentEnder changed the title fix(nx): use argument length that match the actual size of the argument length fix(core): use argument length that match the actual size of the argument length Jul 24, 2024
@AgentEnder AgentEnder merged commit 99a488a into nrwl:master Jul 24, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jul 24, 2024
@BurningEnlightenment
Copy link

If you could switch from execSync to execFileSync without a shell the Windows specific limit would be raised to 32k.

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants