feat(core): create a new function to run child processes via rust #21070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ef6ca5f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
feature/nxc-154-use-the-new-function-in-forked-process-task-runner
branch
from
b1a26c3 to
5ec29ca
Compare
fix(core): add test to check for tty
Cammisuli
force-pushed
the
feature/nxc-154-use-the-new-function-in-forked-process-task-runner
branch
from
57d35e6 to
37d0211
Compare
…iple callbacks for onexit
Cammisuli
force-pushed
the
feature/nxc-154-use-the-new-function-in-forked-process-task-runner
branch
from
97a7ccc to
4de5a7d
Compare
Cammisuli
force-pushed
the
feature/nxc-154-use-the-new-function-in-forked-process-task-runner
branch
from
4de5a7d to
fef0c71
Compare
Cammisuli
force-pushed
the
feature/nxc-154-use-the-new-function-in-forked-process-task-runner
branch
from
bcf403d to
eb50e01
Compare
AgentEnder
approved these changes
Jan 17, 2024
| ): Promise<boolean> { | ||
| env = processEnv(color, cwd, env); | ||
| // The rust runCommand is always a tty, so it will not look nice in parallel and if we need prefixes | ||
| // currently does not work properly in windows |
There was a problem hiding this comment.
Cleanup: fixed - remove in new pr
| @@ -107,7 +120,155 @@ export class ForkedProcessTaskRunner { | |||
| }); | |||
| } | |||
|
|
|||
| public forkProcessPipeOutputCapture( | |||
| public async forkProcessLegacy( | |||
There was a problem hiding this comment.
Cleanup (next pr): add depreciation and todo
FrozenPandaz
deleted the
feature/nxc-154-use-the-new-function-in-forked-process-task-runner
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Using the
commandoption in project targets uses a node implementation that takes away interactivity from the running command. For example, when trying to runjestin a command, we do not see the progress bar.Expected Behavior
The
commandoption will now run a psuedo terminal, where we will be able to see interactivity. This allows Nx to be more seamless when running on workspaces that have pcv3 enabled.The forked process task runner is also updated to use the psuedo terminal as well for forking processes.
Related Issue(s)
Fixes #