feat(nextjs): Standalone projects now default to src #21010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1f0ee64. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
3 times, most recently
from
9467e69 to
065d326
Compare
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
065d326 to
a7c90ae
Compare
jaysoo
reviewed
Jan 10, 2024
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
a7c90ae to
58dd8c5
Compare
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
58dd8c5 to
51cb8b4
Compare
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
51cb8b4 to
6b79866
Compare
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
6b79866 to
ee3d83f
Compare
ndcunningham
requested review from
meeroslav,
vsavkin,
a team,
FrozenPandaz,
AgentEnder and
JamesHenry
as code owners
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
ee3d83f to
b3c3e04
Compare
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
b3c3e04 to
5aed0ea
Compare
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
5aed0ea to
b296522
Compare
mandarini
reviewed
Jan 16, 2024
mandarini
approved these changes
Jan 16, 2024
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
b296522 to
7740934
Compare
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
7740934 to
c685a74
Compare
ndcunningham
force-pushed
the
feat/next-standalone-src
branch
from
c685a74 to
1f0ee64
Compare
ndcunningham
commented
Jan 17, 2024
| @@ -41,7 +42,9 @@ describe('@nx/workspace:convert-to-monorepo', () => { | |||
| expect(() => runCLI(`test ${reactApp}`)).not.toThrow(); | |||
| expect(() => runCLI(`lint ${reactApp}`)).not.toThrow(); | |||
| expect(() => runCLI(`lint e2e`)).not.toThrow(); | |||
| expect(() => runCLI(`e2e e2e`)).not.toThrow(); | |||
| if (runE2ETests()) { | |||
There was a problem hiding this comment.
Added to reduce the test being flaky
jaysoo
approved these changes
Jan 17, 2024
isaacplmann
approved these changes
Jan 17, 2024
Cammisuli
approved these changes
Jan 17, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, when you create a standalone next workspace it does not contain a
src/for the application filesExpected Behavior
Application files are now inside
src/folder for standalone next projects