Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): update migration to handle projects without eslintrc #20932

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Dec 27, 2023

The migration added to 17.2.7 is failing on missing eslintrc files. This PR adds a check before attempting migration.

Current Behavior

Migration fails

Expected Behavior

Migration works

Related Issue(s)

Fixes #20920

Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2023 3:54pm

@jaysoo jaysoo marked this pull request as ready for review December 27, 2023 15:49
@jaysoo jaysoo requested a review from a team as a code owner December 27, 2023 15:49
@jaysoo jaysoo requested a review from mandarini December 27, 2023 15:49
@jaysoo jaysoo self-assigned this Dec 27, 2023
@jaysoo jaysoo merged commit d1a2d45 into nrwl:master Dec 27, 2023
6 checks passed
@jaysoo jaysoo deleted the issue/20920 branch December 27, 2023 19:03
Copy link

github-actions bot commented Jan 2, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration "update-17-2-7" fails if a project does not have .eslintrc.json
2 participants