Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): ensure angular entry point checks are correct #20859

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #20310

@meeroslav meeroslav self-assigned this Dec 20, 2023
@meeroslav meeroslav requested a review from a team as a code owner December 20, 2023 09:40
@meeroslav meeroslav requested a review from JamesHenry December 20, 2023 09:40
Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 20, 2023 3:58pm

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Dec 20, 2023
@meeroslav meeroslav changed the title fix(linter): ensure entry point checks are correct fix(linter): ensure angular entry point checks are correct Dec 20, 2023
@meeroslav meeroslav enabled auto-merge (squash) December 20, 2023 13:33
@meeroslav meeroslav merged commit 3981c90 into nrwl:master Dec 20, 2023
6 checks passed
@skrtheboss
Copy link
Contributor

@meeroslav is this the same as what i have done in #19510? So I can close it?

@meeroslav
Copy link
Contributor Author

Yes, I have closed the other PR.

@meeroslav meeroslav deleted the fix-ng-entry-points branch December 22, 2023 12:00
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/enforce-module-boundaries wants relative import to main lib in secondary entrypoint, but build fails
3 participants