fix(vite): vitest migration add reporters

[mandarini]

• Fixed vitest
• Fixed mode for serve & preview

Related Issue(s)

Fixes #20816 #20804

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Dec 18, 2023 3:21pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fa85165. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=1b464d8ce64106f9bc0c3b8bf68572c07138ad40 --head=fa85165b77472165232888fe9e98e005c02f9a1c --parallel=1
• nx affected --targets=lint,test,build --base=1b464d8ce64106f9bc0c3b8bf68572c07138ad40 --head=fa85165b77472165232888fe9e98e005c02f9a1c --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=1b464d8ce64106f9bc0c3b8bf68572c07138ad40 --head=fa85165b77472165232888fe9e98e005c02f9a1c
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=1b464d8ce64106f9bc0c3b8bf68572c07138ad40 --head=fa85165b77472165232888fe9e98e005c02f9a1c

---

Sent with 💌 from NxCloud.

[viniciusbsneto]

So buildTarget options should override the serve target options? 🤔

[mandarini]

Yes, because ideally there would not be any overriding done, since there are no common options in serve and build. In any case, it's better to configure your project in vite.config.ts!

if this surfaces any errors we can revisit, but we're trying to keep the executor logic as minimal as possible.

[mandarini]

I see how this may seem confusing or wrong, however here's the thing:

When the options are loaded in the executor, the executor loads the main options from build, along with the options under the development configuration, for example:

    "build": {
      "executor": "@nx/vite:build",
      "outputs": ["{options.outputPath}"],
      "defaultConfiguration": "production",
      "options": {
        "outputPath": "dist/apps/my-app",
        "generatePackageJson": false
      },
      "configurations": {
        "development": {
          "mode": "development",
          "watch": true
        },
        "production": {
          "mode": "production"
        }
      }
    },
    "serve": {
      "executor": "@nx/vite:dev-server",
      "options": {
        "buildTarget": "my-app:build"
      },
      "configurations": {
        "development": {
          "buildTarget": "my-app:build:development",
          "hmr": true
        },
        "production": {
          "buildTarget": "my-app:build:production",
          "hmr": false
        }
      }
    },

It's up to the user to make sure these are set the way the user prefers.

In this case, it would load from build the following:

{
        "outputPath": "dist/apps/my-app",
        "generatePackageJson": false,
        "mode": "development",
         "watch": true
 }

And the options that would be loaded from serve would be:

{
          "buildTarget": "my-app:build:development",
          "hmr": true
 }

All these will be simplified in the near future, when we will be moving away from executors, and the logic will be much more transparent.

[viniciusbsneto]

Oh! I see! serve and build targets have different schemas.

So that's why ideally there shouldn't be any overrides. It's the extra args that kinda allows the overriding. That got me confused. Although it's possible to setup mode in the serve target options, it shouldn't be done. Is that correct?

Thanks for the taking the time to explain! 🙇🏻‍♂️

[jindong-zhannng]

Hi friends. I am facing the reporter problem in my project now. Migrating to v17.2.7 seems not working for me, so do I have to wait for a v17.3.x version since I see this PR's migration has a 17.3.0-beta.0 tag?

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.