Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): fixing output based on test runner selection #20788

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

mandarini
Copy link
Member

Current Behavior

Jest is hardcoded regardless of test runner that is selected in the generator

Expected Behavior

generated output should reflect the selected options for accuracy and consistency

Related Issue(s)

Fixes #20571

NOTE: Moved from #20572 because other PR was stuck

@mandarini mandarini requested a review from a team as a code owner December 15, 2023 13:46
@mandarini mandarini requested a review from jaysoo December 15, 2023 13:46
Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 1:47pm

@mandarini mandarini enabled auto-merge (squash) December 15, 2023 13:48
auto-merge was automatically disabled December 15, 2023 15:00

Base branch was modified

@mandarini mandarini merged commit ff624a3 into nrwl:master Dec 15, 2023
6 checks passed
jaysoo pushed a commit that referenced this pull request Dec 18, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS lib incorrectly references jest when test runner is something else (vitest)
3 participants