Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): only dynamically import vite #20774

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Dec 14, 2023

Only dynamically import vite where needed

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 0:24am

@mandarini mandarini force-pushed the fix/dont-import-vite branch from bb4ffdb to 9b0eedb Compare December 14, 2023 18:51
@mandarini mandarini self-assigned this Dec 14, 2023
@mandarini mandarini force-pushed the fix/dont-import-vite branch from 9b0eedb to 9ff57cb Compare December 15, 2023 12:23
@mandarini mandarini marked this pull request as ready for review December 15, 2023 12:23
@mandarini mandarini requested a review from a team as a code owner December 15, 2023 12:23
@mandarini mandarini requested review from JamesHenry and jaysoo and removed request for JamesHenry December 15, 2023 12:24
@mandarini mandarini linked an issue Dec 15, 2023 that may be closed by this pull request
4 tasks
@mandarini mandarini merged commit 7641f73 into nrwl:master Dec 15, 2023
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppression of Vite CJS warning doesn't work
2 participants