Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): disallow path segments and allow scoped package name in --newProjectName option of move generator #20768

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Dec 14, 2023

This PR aligns the move generator handling for project names with the changes made to the project generators in #20274.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #20756

@leosvelperez leosvelperez self-assigned this Dec 14, 2023
Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 2:24pm

@leosvelperez leosvelperez marked this pull request as ready for review December 14, 2023 15:37
@leosvelperez leosvelperez requested a review from a team as a code owner December 14, 2023 15:37
@leosvelperez leosvelperez merged commit 6129d31 into nrwl:master Dec 14, 2023
6 checks passed
@leosvelperez leosvelperez deleted the misc/fix-move-project-name branch December 14, 2023 17:12
jaysoo pushed a commit that referenced this pull request Dec 14, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bypass nx generate @nx/angular:library "You can't specify both a directory and a name with a directory path"
3 participants