Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): handle both nx and nrwl scoped executors when migrating config #20714

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Dec 12, 2023

Previous migration only handled old scope, this PR updates to handle both nx and nrwl scopes.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner December 12, 2023 13:21
@jaysoo jaysoo requested a review from mandarini December 12, 2023 13:21
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 1:24pm

@jaysoo jaysoo merged commit 254ce82 into master Dec 12, 2023
6 checks passed
@jaysoo jaysoo deleted the fix/webpack-migration branch December 12, 2023 14:10
meeroslav pushed a commit to meeroslav/nx that referenced this pull request Dec 14, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants