Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): move should migrate all eslint configs #20709

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

The move generator incorrectly migrates root project, leaving other project's in the standalone mode.

Expected Behavior

The move generator should update eslint configs of other projects as well when migrating root project.

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Dec 12, 2023
@meeroslav meeroslav requested review from a team as code owners December 12, 2023 11:20
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 1:48pm

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Dec 12, 2023
@meeroslav meeroslav merged commit 4314133 into nrwl:master Dec 13, 2023
7 checks passed
@meeroslav meeroslav deleted the fix-move-eslint-with-migration branch December 13, 2023 14:18
meeroslav added a commit to meeroslav/nx that referenced this pull request Dec 14, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants