fix(vite): better extra args resolution #20708
Merged
+103
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
4 tasks
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7a4c969. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
mandarini
force-pushed
the
fix/vite-extra-args-refine
branch
from
5f46303 to
7a4c969
Compare
jaysoo
approved these changes
Dec 12, 2023
jaysoo
pushed a commit
that referenced
this pull request
Dec 12, 2023
meeroslav
pushed a commit
to meeroslav/nx
that referenced
this pull request
Dec 14, 2023
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While getting the extra arguments passed through the CLI, some where missed, or some where passed in wrong places.
This PR fixes these issues.
referencing related PRs and issues:
watchoption from cli is ignored by@nx/vite:test#20706watchoption from CLI to test executor #20707