fix(react): webpack backwards compat for @nx/react/plugin/webpack

[jaysoo]

Now that our Webpack executor supports standard Webpack configuration files, we need to check if the exported function is a standard Webpack function (env, args) -> config or Nx-specific funtion (config, nxContext) -> config. To be treated as an Nx-specific function, it needs to be called with composePlugins, otherwise @nx/webpack:webpack executor will pass the function to Webpack as a standard config.

This means that legacy setup with this in project.json...

build: {
  options: { 
    //...
    webpackConfig: '@nx/react/plugins/webpack'
  }
}

...will no longer build since @nx/react/plugin/webpack does not run through composePlugins.

Current Behavior

Build is broken

Expected Behavior

Build works

Related Issue(s)

Fixes #20669

Notes

Also removes getWebpackConfig function that we deprecated in Nx 14 and was supposed to remove in Nx 16.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)		Dec 11, 2023 6:33pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 83c961a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=b7a237b9d3c2159f035ecc9ab0ad3b2168ee1a2c --head=83c961a17f6d33dc3f7e9ab1fce9dd46d61bf046 --parallel=1
• nx affected --targets=lint,test,build --base=b7a237b9d3c2159f035ecc9ab0ad3b2168ee1a2c --head=83c961a17f6d33dc3f7e9ab1fce9dd46d61bf046 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=b7a237b9d3c2159f035ecc9ab0ad3b2168ee1a2c --head=83c961a17f6d33dc3f7e9ab1fce9dd46d61bf046
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=b7a237b9d3c2159f035ecc9ab0ad3b2168ee1a2c --head=83c961a17f6d33dc3f7e9ab1fce9dd46d61bf046

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.