Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix): add remix #20641

Merged
merged 3 commits into from
Dec 13, 2023
Merged

feat(remix): add remix #20641

merged 3 commits into from
Dec 13, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Dec 7, 2023

Current Behavior

Remix support currently lives in nx-labs

Expected Behavior

Remix support should be in nx

Related Issue(s)

Fixes #

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 12, 2023 3:56pm

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting seems to be missing for remix application.

Also package.json and .eslintrc don't seem to be optimally configured.

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with small comment

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with small comment

@AgentEnder AgentEnder merged commit 3b5bf6d into nrwl:master Dec 13, 2023
6 checks passed
@Coly010 Coly010 deleted the remix/move-to-repo branch December 13, 2023 16:26
meeroslav pushed a commit to meeroslav/nx that referenced this pull request Dec 14, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants