Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): allow custom media images #20561

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

isaacplmann
Copy link
Collaborator

@isaacplmann isaacplmann commented Dec 4, 2023

Allows you to specify custom media images in map.json

Add a mediaImage property in the entry in map.json. The path is relative to /docs and no title or content text will be written over the top of the image.

Note the previews won't have the correct social media image because the social media image points to the live nx.dev site. You can verify your social media images by viewing [preview url]/images/open-graph/ci-features-remote-cache.jpg and replacing ci-features-remote-cache with the url for your page.

@isaacplmann isaacplmann requested a review from a team as a code owner December 4, 2023 13:54
@isaacplmann isaacplmann requested a review from vsavkin December 4, 2023 13:54
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 5, 2023 7:12pm

Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also update the docs/README to include this possibility so ppl know

scripts/documentation/open-graph/generate-images.ts Outdated Show resolved Hide resolved
@isaacplmann isaacplmann merged commit cf976ce into nrwl:master Dec 7, 2023
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants