Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): infer serve-static target correctly from plugin #20511

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 30, 2023

This PR fixes the serve-static target that @nx/webpack/plugin adds.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner November 30, 2023 17:57
@jaysoo jaysoo requested a review from JamesHenry November 30, 2023 17:57
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 5:58pm

@jaysoo jaysoo force-pushed the feat/file-server-build-target branch from e12637b to 58b4c35 Compare November 30, 2023 17:58
@jaysoo jaysoo changed the title Feat/file server build target fix(webpack): infer serve-static target correctly from plugin Nov 30, 2023
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mandarini mandarini merged commit d051abc into nrwl:master Nov 30, 2023
2 checks passed
@jaysoo jaysoo deleted the feat/file-server-build-target branch November 30, 2023 19:47
Copy link

github-actions bot commented Dec 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants