Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): support buildTarget that excludes project name #20508

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 30, 2023

This PR allows use to define file-server target as follows:

executor: "@nx/web:file-server",
options: {
  buildTarget: 'build'
}

Previously, we had to provide the project name like <proj>:build or else this executor won't work.

Current Behavior

Project name is required

Expected Behavior

Project name is optional

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner November 30, 2023 16:59
@jaysoo jaysoo requested a review from AgentEnder November 30, 2023 16:59
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 5:00pm

@jaysoo jaysoo merged commit 2d529b1 into nrwl:master Nov 30, 2023
6 checks passed
@jaysoo jaysoo deleted the feat/file-server-build-target branch November 30, 2023 17:54
Copy link

github-actions bot commented Dec 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants