-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): support esbuild-based executors/builders in @nx/angular:dev-server #20311
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 661ba17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
8852e78
to
661ba17
Compare
@leosvelperez thanks for the PR! Two questions:
|
Yes.
Not yet. We'll look into supporting that separately. Please note the Angular CLI builders only support plugins when consuming the builder programmatically, not when running a target through the CLI. So, with the changes on this PR you'll already have the same functionality the Angular CLI builders have to run your project targets. Later, Nx executors will add on top of that and expose a way to provide plugins in your project target configuration. |
@leosvelperez I get a schema error when using Data path "" must NOT have additional properties(indexFileTransformer). If I comment the code in the Angular source code it works. How do we solve it without changing the Angular source code? |
One more issue when running nx build production: NX 'indexFileTransformer' is not found in schema |
I also get warnings: Project 'ui' contains extension with invalid name ($schema). |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
@nx/angular:webpack-dev-server
to@nx/angular:dev-server
@angular-devkit/build-angular:dev-server
to use esbuild when the build target executor is@nx/angular:browser-esbuild
Current Behavior
The
@nx/angular:webpack-dev-server
is a webpack-specific executor that doesn't support the esbuild-based executors/builders.Expected Behavior
The
@nx/angular:webpack-dev-server
should be renamed to@nx/angular:dev-server
and support the esbuild-based executors/builders.Related Issue(s)
Fixes #20267
Fixes #20332