-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module-federation): add tsconfig file for linting with TS webpack #20150 #20210
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5b4f963. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
4077b26
to
e1c2348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always generate that file regardless of the value of the setParserOptionsProject
option. I think we should only generate the extra config file if that option is set. Otherwise, we don't need it. Given how little this has been requested, I'd guess this is not too common. So, keeping the amount of config files as low as possible is better.
Good point |
e1c2348
to
5b4f963
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Newly generated remote with TS config is failing lint with parser options
Expected Behavior
Newly generated remote should not fail
Related Issue(s)
Fixes #20150