Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-federation): add tsconfig file for linting with TS webpack #20150 #20210

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Nov 13, 2023

Current Behavior

Newly generated remote with TS config is failing lint with parser options

Expected Behavior

Newly generated remote should not fail

Related Issue(s)

Fixes #20150

@Coly010 Coly010 requested review from a team as code owners November 13, 2023 11:32
@Coly010 Coly010 requested a review from ndcunningham November 13, 2023 11:32
@Coly010 Coly010 self-assigned this Nov 13, 2023
Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 13, 2023 3:59pm

@Coly010 Coly010 force-pushed the fix/mf-tsconfig-lint-remotes branch from 4077b26 to e1c2348 Compare November 13, 2023 11:38
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always generate that file regardless of the value of the setParserOptionsProject option. I think we should only generate the extra config file if that option is set. Otherwise, we don't need it. Given how little this has been requested, I'd guess this is not too common. So, keeping the amount of config files as low as possible is better.

@Coly010
Copy link
Contributor Author

Coly010 commented Nov 13, 2023

Good point

@Coly010 Coly010 merged commit c7c845d into nrwl:master Nov 13, 2023
6 checks passed
@Coly010 Coly010 deleted the fix/mf-tsconfig-lint-remotes branch November 13, 2023 16:44
FrozenPandaz pushed a commit that referenced this pull request Nov 13, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint fails for newly generated angular remote application
4 participants