-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): add option for @nx/dependency-checks to update workspace dependencies using local file paths #20157
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit be8e9e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
…e dependencies using local file paths
@jaysoo your build is broken. Can you please check this out, to get your feature with the next Nx release :) |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 45b94c2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR adds
useLocalPathsForWorkspaceDependencies
option to@nx/dependency-checks
lint rule so that when using--fix
, it can use a local path (e.g.file:../foobar
) rather than the current*
value.Also, when
useLocalPathsForWorkspaceDependencies
isfalse
orundefined
, the value is read from the source/committedpackage.json
file of the dependency rather than using*
. This way users can use the committed versions if that is how they manage releases, or set the version to*
if desired.Another benefit is that committed versions are now also checked to ensure version ranges match their dependencies' versions.
Current Behavior
Expected Behavior
Related Issue(s)
Related #19989