fix(angular): use esm2022 for secondary entrypoints in ng-packagr-lite executor #20130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in ng-package-lite
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8886a7c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
still can't build my angular project with incremental esbuild and a library with secondary entrypoints... I guess this is the fix for that, as this is supposed to be fixed in ng-packagr now... |
leosvelperez
requested changes
Nov 14, 2023
...ors/ng-packagr-lite/ng-packagr-adjustments/ng-package/entry-point/write-package.transform.ts
Outdated
Show resolved
Hide resolved
leosvelperez
changed the title
leosvelperez
approved these changes
Nov 14, 2023
…secondary-entrypoints
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 14, 2023
…e executor (#20130) Co-authored-by: Leosvel Pérez Espinosa <[email protected]> (cherry picked from commit 96043fb)
skrtheboss
deleted the
fix/use-correct-budle-in-ng-packager-lite-secondary-entrypoints
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #