Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(angular): remove unneeded stubbing for performance.mark in jest setup file #20120

Conversation

leosvelperez
Copy link
Member

Stubbing performance.mark for Jest tests is no longer needed after this change in Angular angular/angular@80e7a0f. This PR removes the associated generator code and migration.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Nov 8, 2023
@leosvelperez leosvelperez requested a review from a team as a code owner November 8, 2023 11:45
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 2:06pm

@leosvelperez leosvelperez force-pushed the angular/remove-performance.mark-stubbing branch from f3828f1 to 8760ff5 Compare November 8, 2023 12:01
@leosvelperez
Copy link
Member Author

Failing tests are solved by #20122

@leosvelperez leosvelperez force-pushed the angular/remove-performance.mark-stubbing branch from 8760ff5 to fb0f0cc Compare November 8, 2023 14:05
@leosvelperez leosvelperez merged commit 304a6d1 into nrwl:master Nov 8, 2023
2 checks passed
@leosvelperez leosvelperez deleted the angular/remove-performance.mark-stubbing branch November 8, 2023 14:39
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants