Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): always load nxignore last for highest priority #20104

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Nov 7, 2023

Current Behavior

when loading ignore files, the underlying framework uses async mechanisms to read these files. Even if we pass the files in a set order, the async nature would be FutureUnordered. This causes the nxignore to sometimes be loaded before gitignore, where we always want it to be loaded last.

Expected Behavior

The nxignore file is added after all other ignore files have been read and loaded.

  • Also added bonus of stabilizing the watcher unit tests

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested review from a team as code owners November 7, 2023 18:53
@Cammisuli Cammisuli requested a review from AgentEnder November 7, 2023 18:53
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 7:51pm

@Cammisuli Cammisuli changed the title fix(core): stabilize watcher unit tests fix(core): always load nxignore last for highest priority Nov 7, 2023
@Cammisuli Cammisuli enabled auto-merge (squash) November 7, 2023 21:05
@Cammisuli Cammisuli merged commit d4ef5c0 into nrwl:master Nov 7, 2023
2 checks passed
@Cammisuli Cammisuli deleted the master branch November 7, 2023 21:14
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants