Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-cloud): fallback to nx-cloud bin if enterprise is outdated and… #20098

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

… migrate properly

Current Behavior

When Nx Enterprise customers update, there's a chance that the bin from nx overrides the bin from the nx-cloud package.

Expected Behavior

When running nx-cloud commands fails due to the NxEnterprise instance being out of date, it tries to fallback to the nx-cloud bin which has a built in version of the commands.

In addition, useLightClient is set to true if during the migration, it is unable to verify the Nx Cloud client.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner November 7, 2023 14:53
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 2:54pm

@FrozenPandaz FrozenPandaz merged commit c2d63af into nrwl:master Nov 7, 2023
2 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-cloud-bin-override branch November 7, 2023 20:47
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants