Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): import path info on federated module #20091

Merged

Conversation

raketeFlo
Copy link
Contributor

@raketeFlo raketeFlo commented Nov 7, 2023

Current Behavior

When generating a federated module the logger shows an example import in the terminal. However, the import path is wrong.
Screenshot 2023-11-07 at 14 16 51

Expected Behavior

The import path for the newly generated module should be displayed correctly.
import { MyComponent } from 'dashboard/widgetA';
import('dashboard/widgetA').then((m) => m.widgetA);

@raketeFlo raketeFlo requested a review from a team as a code owner November 7, 2023 13:49
@raketeFlo raketeFlo requested a review from xiongemi November 7, 2023 13:49
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 7, 2023 1:57pm

Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@ndcunningham ndcunningham merged commit 9330513 into nrwl:master Nov 8, 2023
2 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants