feat(core): extglob to standard glob parser #20089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cammisuli
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e0a448a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Cammisuli
force-pushed
the
feature/nxc-116-extglob-to-standard-glob-parser
branch
2 times, most recently
from
d6bb317 to
2704ead
Compare
Cammisuli
force-pushed
the
feature/nxc-116-extglob-to-standard-glob-parser
branch
from
2704ead to
e0a448a
Compare
FrozenPandaz
approved these changes
Nov 10, 2023
Cammisuli
deleted the
feature/nxc-116-extglob-to-standard-glob-parser
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Current native glob implementation has a naive approach to handle extglobs. Where it only handles negated groups (
!()) using regexExpected Behavior
The extglob is now parsed and we are able to handle
@(),!(),?(),+(),*()patterns. Although, there are still some limitations:*(a|b|c)&&?(a|b|c)behave the same+(a|b|c)&&@(a|b|c)behave the sameRelated Issue(s)
Fixes #