fix(nextjs): re-enable storybook test #20074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 00d68f4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
mandarini
force-pushed
the
fix/re-enable-next-sb-test
branch
2 times, most recently
from
c6454ea to
8cfc098
Compare
mandarini
force-pushed
the
fix/re-enable-next-sb-test
branch
from
8cfc098 to
00d68f4
Compare
jaysoo
approved these changes
Nov 7, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #19661
The
e2e-next-extensionssuite fails for Storybook+Next with the following error:On normal (non-CI) environments, it works fine (
nx build-storybook my-nest-appworks fine).I noticed that when I opened the project that was generated by the E2E test, and ran
nx build-storybookthere, the same issue appeared. Once I installed the dependencies again (npm i), the error went away. There must be an issue with the first install in the e2e tests. So, callingnpm iagain fixes the issue on e2e, too.