Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): migrate custom ignorePath to flat config #20017

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

  • Flat config converter does not respect ignorePath
  • Flat config converter removes ignore file during the conversion of the config, which can lead to issues if some other project references the same ignore file.

Expected Behavior

  • Flat config converter should respect ignorePath and clean it up after the conversion
  • Converter should remove ignore files only once all the projects have been converted

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Nov 2, 2023
@meeroslav meeroslav self-assigned this Nov 2, 2023
@meeroslav meeroslav requested a review from a team as a code owner November 2, 2023 20:57
Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 8:59pm

@meeroslav meeroslav force-pushed the fix-flat-custom-ignore-paths branch from a7b2ce4 to 66c28ee Compare November 2, 2023 20:58
@meeroslav meeroslav requested a review from JamesHenry November 2, 2023 21:01
@JamesHenry JamesHenry merged commit f421716 into nrwl:master Nov 5, 2023
2 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants