-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): filtering of local dependencies when running nx release version
#19995
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f910106. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Thank you @kraenhansen! You're not only using an undocumented alpha feature but also submitting fixes for it to 💙 Please do be aware thought that there are likely some more breaking config changes coming within the next couple of weeks that will not be automatically migrated. As soon as we document it and remove that alpha label, all the usual migrations etc will be applied to future versions |
nx release version
nx release version
Head branch was pushed to by a user without write access
746a380
to
72b726f
Compare
Head branch was pushed to by a user without write access
72b726f
to
f910106
Compare
The failures seem unrelated to my change or at least from what I can see. I just rebased, to give the tests another go. |
Thanks again @kraenhansen! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This closes #19990 by moving the
filter
onto the flat list of local dependencies instead of requiring just one of the local dependencies to match thetarget
.Current Behavior
If just one local dependent project / dependency match the
target
all dependents would be included asdependentProjects
resulting in the behaviour outlined in #19990.Expected Behavior
The
dependentProjects
include only dependent projects / local dependencies that are actually relevant for a particularproject
, resulting in the expectedpackage.json
when runningnx release version
.Related Issue(s)
Fixes #19990