Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): filtering of local dependencies when running nx release version #19995

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

kraenhansen
Copy link
Contributor

This closes #19990 by moving the filter onto the flat list of local dependencies instead of requiring just one of the local dependencies to match the target.

Current Behavior

If just one local dependent project / dependency match the target all dependents would be included as dependentProjects resulting in the behaviour outlined in #19990.

Expected Behavior

The dependentProjects include only dependent projects / local dependencies that are actually relevant for a particular project, resulting in the expected package.json when running nx release version.

Related Issue(s)

Fixes #19990

@kraenhansen kraenhansen requested a review from a team as a code owner November 2, 2023 13:23
Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2023 5:33pm

@JamesHenry
Copy link
Collaborator

Thank you @kraenhansen! You're not only using an undocumented alpha feature but also submitting fixes for it to 💙

Please do be aware thought that there are likely some more breaking config changes coming within the next couple of weeks that will not be automatically migrated.

As soon as we document it and remove that alpha label, all the usual migrations etc will be applied to future versions

@JamesHenry JamesHenry enabled auto-merge (squash) November 6, 2023 11:14
@JamesHenry JamesHenry changed the title fix(js): fix filtering of local dependencies when running nx release version fix(js): filtering of local dependencies when running nx release version Nov 6, 2023
auto-merge was automatically disabled November 6, 2023 16:12

Head branch was pushed to by a user without write access

@AgentEnder AgentEnder enabled auto-merge (squash) November 6, 2023 16:16
auto-merge was automatically disabled November 11, 2023 17:32

Head branch was pushed to by a user without write access

@kraenhansen
Copy link
Contributor Author

The failures seem unrelated to my change or at least from what I can see. I just rebased, to give the tests another go.

@JamesHenry JamesHenry merged commit b90e300 into nrwl:master Nov 13, 2023
2 checks passed
@JamesHenry
Copy link
Collaborator

Thanks again @kraenhansen!

@kraenhansen kraenhansen deleted the fix-19990 branch November 13, 2023 18:17
FrozenPandaz pushed a commit that referenced this pull request Nov 13, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx release version duplicates local packages across "dev" and "prod" dependencies
2 participants