-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module-federation): use nx run-many to build static remotes in parallel #19987
feat(module-federation): use nx run-many to build static remotes in parallel #19987
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8b2758e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
fcf14cb
to
8b2758e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine just not sure what ANSII_CODE_REGEX
means.
It's a regex to find the codes that output certain strings in the terminal in different colors or as bold text. They aren't being stripped without that regex and therefore matching strings fails because
There's a similar util used in our e2e suites |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
We currently spin up a new forked process for every build of a static remote. This impacts resources and memory consumption when there are a lot of remotes in the workspace.
Expected Behavior
We should use nx run-many instead to manage parallel builds of static remotes allowing for users to find the perfect number of parallel processes that they can use to build static remotes locally.
Related Issue(s)
Fixes #