fix(core): ensure project order in graph is deterministic #19968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
AgentEnder
requested review from
FrozenPandaz
and removed request for
JamesHenry
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9061a9d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/sort-implicit-dependencies-before-hashing
branch
from
8e6239c to
a50d6f0
Compare
AgentEnder
force-pushed
the
fix/sort-implicit-dependencies-before-hashing
branch
from
a50d6f0 to
9061a9d
Compare
Cammisuli
approved these changes
Nov 1, 2023
AgentEnder
changed the title
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit c83afeb)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The hash of the project configuration can change every run when using implicit dependencies configurations that contain glob patterns.
Expected Behavior
The project configuration hash is stable when the implicit dependencies have not changed. This is a pretty major issue, and a better fix would likely be to figure out why the order isn't deterministic to begin with, but it would be a larger PR and isn't obvious after looking over the code for a bit. I think the glob results are being processed in a different order when creating the graph nodes, and thats a lot harder to fix than just sorting the normalized array when we hash tasks.
Related Issue(s)
Fixes #19820