Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): move test config more into nx.json targetDefaults #19963

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

jest targets have a lot of the same options added to them in project.json

test target defaults are all added to nx.json defaults under test which leads to some weird cases when both vitest and jest are used when jest.preset.js will be an input for vitest tasks.

Expected Behavior

Common jest options are added to nx.json under targetDefaults so the options are not added to project.json.

Target defaults for test executors are added under the executor so @nx/jest:jest settings are separate from @nx/vite:vitest settings.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 10:34pm

@FrozenPandaz FrozenPandaz force-pushed the jest-defaults branch 2 times, most recently from 942b034 to e607087 Compare October 31, 2023 22:04
@FrozenPandaz FrozenPandaz marked this pull request as ready for review November 1, 2023 13:16
@FrozenPandaz FrozenPandaz requested review from a team as code owners November 1, 2023 13:16
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) November 1, 2023 14:12
@FrozenPandaz FrozenPandaz merged commit 8a89df6 into nrwl:master Nov 1, 2023
2 checks passed
Copy link

github-actions bot commented Nov 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants