Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): nuxt executors, generators, docs #19855

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Oct 25, 2023

built on top of #19524

This PR contains the following:

  • Updated generators for adding vitest to a nuxt app
  • Updated generators for adding jest to a nuxt app (however jest does not run properly)
  • build executor
  • serve executor
  • Added the setup-tailwind generator
  • Added prompt for style in nuxt:app generator

Also contains the create-nx-workspace nuxt presets.

To test it out:

nx g @nx/nuxt:app my-app --unitTestRunner=vitest

then

nx build my-app

and

nx serve my-app

And to test the testing feature, you first need to generate a component with tests, so:

nx g @nx/nuxt:component --unitTestRunner=vitest

and then:

nx test my-app

merging this PR will solve the Lint problems, because we need TypeScript 5.2.2.

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 7, 2023 2:58pm

@jaysoo
Copy link
Member

jaysoo commented Oct 26, 2023

Just a quick comment that we should add PCv3 from the get-go, but it should be a follow-up PR.

@mandarini mandarini force-pushed the feat/nuxt-exec branch 2 times, most recently from db6813b to a0a14f9 Compare October 26, 2023 17:12
@mandarini mandarini force-pushed the feat/nuxt-exec branch 2 times, most recently from c4e924e to 927f366 Compare October 30, 2023 09:53
@mandarini mandarini force-pushed the feat/nuxt-exec branch 4 times, most recently from c7eeddf to 5bfa7d7 Compare October 31, 2023 20:26
@barbados-clemens barbados-clemens added scope: angular Issues related to Angular support in Nx and removed scope: angular Issues related to Angular support in Nx labels Oct 31, 2023
@mandarini mandarini marked this pull request as ready for review November 1, 2023 10:23
@mandarini mandarini requested review from a team as code owners November 1, 2023 10:23
@mandarini
Copy link
Member Author

Using nightly release of nuxi because: nuxt/cli#274

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good

@mandarini mandarini merged commit b342367 into nrwl:master Nov 7, 2023
2 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants