Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): remove parcel/watcher #19751

Merged

Conversation

Cammisuli
Copy link
Member

Current Behavior

Current daemon implementation has both a rust watcher and a parcel/watcher implementation.

Expected Behavior

Only the rust watcher should be used as it handles nested gitignores better

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested a review from a team as a code owner October 20, 2023 11:34
@Cammisuli Cammisuli requested a review from AgentEnder October 20, 2023 11:34
@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 4:53pm

@Cammisuli Cammisuli force-pushed the feature/nxc-60-remove-parcelwatcher branch from d4e7bf3 to 8a09c5b Compare October 20, 2023 12:02
@Cammisuli Cammisuli added the PR status: do not merge This will block a PR from being merged until this tag is removed. label Oct 20, 2023
@Cammisuli Cammisuli changed the title chore(core): remove parcel/watcher feat(core): remove parcel/watcher Oct 20, 2023
@Cammisuli Cammisuli force-pushed the feature/nxc-60-remove-parcelwatcher branch from 8a09c5b to c418b07 Compare October 20, 2023 16:53
@Cammisuli Cammisuli removed the PR status: do not merge This will block a PR from being merged until this tag is removed. label Oct 20, 2023
@dbjorge
Copy link

dbjorge commented Oct 20, 2023

This should incidentally fix #19457 and #13973

@FrozenPandaz FrozenPandaz merged commit f19d1db into nrwl:master Oct 20, 2023
2 of 3 checks passed
@Cammisuli Cammisuli deleted the feature/nxc-60-remove-parcelwatcher branch October 21, 2023 00:09
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants