Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): check filePath existence first #19749

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix(linter): check filePath existence first #19749

merged 1 commit into from
Nov 6, 2023

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Oct 20, 2023

Current Behavior

crash if a file path does not exist

Expected Behavior

no crash

Related Issue(s)

Fixes #19748

@JounQin JounQin requested a review from a team as a code owner October 20, 2023 09:19
@JounQin JounQin requested a review from meeroslav October 20, 2023 09:19
@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 9:20am

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the PR

@meeroslav meeroslav self-assigned this Nov 6, 2023
@meeroslav meeroslav merged commit b286865 into nrwl:master Nov 6, 2023
2 checks passed
@JounQin JounQin deleted the fix/lstat_error branch November 6, 2023 16:46
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lstatSync could throw on checking getRelativeImportPath
2 participants