Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): Update error message for invalid remote name #19744

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(react): Update error message for invalid remote name #19744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/angular/src/utils/mf/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,14 @@ export function getFunctionDeterminateRemoteUrl(isServer: boolean = false) {
const remoteEntry = isServer ? 'server/remoteEntry.js' : 'remoteEntry.mjs';

return function (remote: string) {
const remoteConfiguration = readCachedProjectConfiguration(remote);
let remoteConfiguration = null;
try {
remoteConfiguration = readCachedProjectConfiguration(remote);
} catch (e) {
throw new Error(
`Cannot find remote "${remote}". Check that the remote name is correct in your module federation config file.\n`
);
}
ndcunningham marked this conversation as resolved.
Show resolved Hide resolved
const serveTarget = remoteConfiguration?.targets?.[target];

if (!serveTarget) {
Expand Down
6 changes: 5 additions & 1 deletion packages/nx/src/project-graph/project-graph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ export function readCachedProjectConfiguration(
): ProjectConfiguration {
const graph = readCachedProjectGraph();
const node = graph.nodes[projectName];
return node.data;
try {
return node.data;
} catch (e) {
throw new Error(`Cannot find project: '${projectName}' in your workspace.`);
}
}

/**
Expand Down
9 changes: 8 additions & 1 deletion packages/react/src/module-federation/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@ export function getFunctionDeterminateRemoteUrl(isServer: boolean = false) {
const remoteEntry = isServer ? 'server/remoteEntry.js' : 'remoteEntry.js';

return function (remote: string) {
const remoteConfiguration = readCachedProjectConfiguration(remote);
let remoteConfiguration = null;
try {
remoteConfiguration = readCachedProjectConfiguration(remote);
} catch (e) {
throw new Error(
`Cannot find remote: "${remote}". Check that the remote name is correct in your module federation config file.\n`
);
}
const serveTarget = remoteConfiguration?.targets?.[target];

if (!serveTarget) {
Expand Down