Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): add migration for eslint config prettier #19732

Merged

Conversation

mandarini
Copy link
Member

Current Behavior

No migration existed. User nx migrates to 17, npm i gives version mismatch error because eslint-config-prettier is still on v8.

Expected Behavior

Update eslint-config-prettier when nx migrate 17.

Related PR: #19232

@mandarini mandarini self-assigned this Oct 19, 2023
@mandarini mandarini requested a review from a team as a code owner October 19, 2023 10:32
@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 0:38am

@mandarini mandarini force-pushed the fix/eslint-config-prettier-version branch from 3cffc2e to 9af9fe7 Compare October 19, 2023 10:53
@mandarini mandarini requested a review from a team as a code owner October 19, 2023 10:53
@mandarini mandarini requested a review from jaysoo October 19, 2023 10:53
@mandarini mandarini enabled auto-merge (squash) October 19, 2023 12:30
@mandarini mandarini force-pushed the fix/eslint-config-prettier-version branch from 9af9fe7 to d04b7f2 Compare October 19, 2023 12:38
@FrozenPandaz FrozenPandaz disabled auto-merge October 19, 2023 13:27
@FrozenPandaz FrozenPandaz merged commit ef4ffe9 into nrwl:master Oct 19, 2023
2 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants