Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): respect unitTestRunner none and inform about vitest #19676

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

mandarini
Copy link
Member

Current Behavior

When generating React or Web app using Vite, vitest is enforced. This makes sense, but only if the user has not chosen none as unitTestRunner. However user is not informed.

Expected Behavior

  • Inform user that choosing vite as bundler defaults to vitest as unitTestRunner unless they choose none.
  • Respect none

Related Issue(s)

Fixes #19152

@mandarini mandarini requested review from a team as code owners October 18, 2023 07:08
@mandarini mandarini requested review from jaysoo and rarmatei October 18, 2023 07:08
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 18, 2023 1:13pm

@mandarini mandarini self-assigned this Oct 18, 2023
@jaysoo jaysoo merged commit 3df8529 into nrwl:master Oct 18, 2023
2 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react:app generator with --bundler=vite ignores --unitTestRunner
2 participants