Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(linter): update docs for eslint package #19649

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Oct 17, 2023

Important: This should be merged after v17 is released

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 17, 2023 1:39pm

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Oct 17, 2023
docs/shared/reference/sitemap.md Show resolved Hide resolved
@@ -0,0 +1,39 @@
The Linter plugin contains executors, generator, plugin and utilities used for linting JavaScript/TypeScript projects within an Nx workspace.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say the ESLint plugin?

@@ -0,0 +1,39 @@
The Linter plugin contains executors, generator, plugin and utilities used for linting JavaScript/TypeScript projects within an Nx workspace.

## Setting Up Linter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Setting Up Linter
## Setting Up ESLint

@FrozenPandaz FrozenPandaz added the PR status: do not merge This will block a PR from being merged until this tag is removed. label Oct 17, 2023
@FrozenPandaz FrozenPandaz removed the PR status: do not merge This will block a PR from being merged until this tag is removed. label Oct 19, 2023
@FrozenPandaz FrozenPandaz merged commit b30f3c5 into nrwl:master Oct 19, 2023
2 of 3 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants