Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): fix flaky test #19625

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

meeroslav
Copy link
Contributor

This test assumes both 4200 and 4201 are free but only kills 4200 before the test.
If 4201 is not cleaned up, it can cause test to fail.

The fix ensures both are cleared.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Oct 16, 2023
@meeroslav meeroslav requested a review from a team as a code owner October 16, 2023 10:20
@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2023 10:21am

@meeroslav meeroslav merged commit a71eb1b into nrwl:master Oct 16, 2023
2 checks passed
@meeroslav meeroslav deleted the fix-flaky-cypress-test branch October 16, 2023 10:35
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants