Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): remove projectNameAndRootFormat from nx.json schema #19623

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Oct 16, 2023

Current Behavior

The nx.json schema still contains a definition for workspaceLayout.projectNameAndRootFormat even though it was meant to be removed in #19218.

Expected Behavior

The nx.json schema should not contain a definition for workspaceLayout.projectNameAndRootFormat.

Related Issue(s)

Fixes #19525

@leosvelperez leosvelperez self-assigned this Oct 16, 2023
@leosvelperez leosvelperez requested review from a team, FrozenPandaz and vsavkin as code owners October 16, 2023 08:10
@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 16, 2023 8:16am

@FrozenPandaz FrozenPandaz merged commit 5ff1531 into nrwl:master Oct 16, 2023
2 checks passed
@leosvelperez leosvelperez deleted the misc/remove-project-name-root-format-nx-json-schema branch October 16, 2023 13:16
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workspaceLayout.projectNameAndFormat is sometimes ignored by generators
2 participants