feat(core): add support for wildcards in dependsOn #19611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 45ac9aa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
|
@AgentEnder @FrozenPandaz guys, can you evaluate this idea, please? |
|
@AgentEnder @FrozenPandaz guys?.. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 081155f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
1 task
|
@FrozenPandaz @AgentEnder maybe now is the better time to look at it? It even passed all the tests :) |
AgentEnder
force-pushed
the
depends-on-wildcard
branch
3 times, most recently
from
212d0a6 to
a9dd434
Compare
AgentEnder
force-pushed
the
depends-on-wildcard
branch
from
a9dd434 to
147747e
Compare
AgentEnder
force-pushed
the
depends-on-wildcard
branch
3 times, most recently
from
6dfbcac to
25efd07
Compare
AgentEnder
force-pushed
the
depends-on-wildcard
branch
from
25efd07 to
b6874c0
Compare
AgentEnder
force-pushed
the
depends-on-wildcard
branch
from
b6874c0 to
68cbe6c
Compare
Now it is possible to define targets like this:
```
{
"targets": {
"build-css": {},
"build-js": {},
"test": {
"dependsOn": ["build-*"]
},
}
}
```
AgentEnder
force-pushed
the
depends-on-wildcard
branch
from
68cbe6c to
f553649
Compare
AgentEnder
force-pushed
the
depends-on-wildcard
branch
from
f553649 to
f231a89
Compare
FrozenPandaz
requested changes
Jul 3, 2024
AgentEnder
force-pushed
the
depends-on-wildcard
branch
from
f231a89 to
081155f
Compare
FrozenPandaz
approved these changes
Jul 8, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 8, 2024
Now it is possible to define targets like this:
```
{
"targets": {
"build-css": {},
"build-js": {},
"test": {
"dependsOn": ["build-*"]
},
}
}
```
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
## Current Behavior
No support for wildcard target dependencies.
## Expected Behavior
This PR is an example of what I described here:
#19414.
## Related Issue(s)
Closes #19414
---------
Co-authored-by: Craigory Coppola <[email protected]>
(cherry picked from commit 3e0d2de)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to define targets like this:
Current Behavior
No support for wildcard target dependencies.
Expected Behavior
This PR is an example of what I described here: #19414.
Related Issue(s)
Closes #19414