Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nx-dev): add links to nxconf talk videos #19590

Merged

Conversation

juristr
Copy link
Member

@juristr juristr commented Oct 12, 2023

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@juristr juristr requested a review from a team as a code owner October 12, 2023 20:45
@juristr juristr requested a review from bcabanes October 12, 2023 20:45
@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 13, 2023 7:50pm

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken link

@@ -42,8 +42,7 @@ export function ConfScheduleShort(): JSX.Element {
title: 'Keynote',
description: '',
speakers: ['Juri Strumpflohner', 'Victor Savkin'],
videoUrl:
'https://www.youtube.com/live/IQ5YyEYZw68?si=TQRfAG7CtNbd3Xu4&t=250',
videoUrl: 'https://youtu.be/a7ggRWYqX3s',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This links to a video that doesn't exist any more

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@juristr juristr force-pushed the update-nx-conf-with-links-to-videos branch from 0819bed to d17a75a Compare October 13, 2023 19:39
@isaacplmann isaacplmann merged commit d36194a into nrwl:master Oct 13, 2023
2 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants