Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(react): fix react module federation with ssr #19565

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Oct 11, 2023

… remote

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #19394

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2023 0:06am

@xiongemi xiongemi changed the title bugfix(react): fix error for running server target for react host and… bugfix(react): fix error for running server target for react mfe Oct 11, 2023
@xiongemi xiongemi changed the title bugfix(react): fix error for running server target for react mfe bugfix(react): fix error for running server target Oct 11, 2023
@xiongemi xiongemi force-pushed the bugfix/fix-build-css-remote branch 3 times, most recently from 50c202d to d2fbca6 Compare October 12, 2023 00:17
@xiongemi xiongemi changed the title bugfix(react): fix error for running server target bugfix(react): fix react module federation with ssr Oct 12, 2023
@xiongemi xiongemi force-pushed the bugfix/fix-build-css-remote branch 9 times, most recently from 06254ef to dc211ef Compare October 12, 2023 21:56
@xiongemi xiongemi force-pushed the bugfix/fix-build-css-remote branch from dc211ef to d7442f8 Compare October 13, 2023 00:06
@xiongemi xiongemi marked this pull request as ready for review October 13, 2023 14:17
@xiongemi xiongemi requested review from a team as code owners October 13, 2023 14:17
@xiongemi xiongemi requested a review from ndcunningham October 13, 2023 14:17
@xiongemi xiongemi merged commit 6e2dba9 into nrwl:master Oct 13, 2023
2 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Module Federation with SSR not working
2 participants