Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): storybook generators #19529

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Oct 10, 2023

  • @nx/nuxt:storybook-configuration
  • @nx/nuxt:stories

Invoking the @nx/vue generators, since Storybook does not officially support any nuxt-specific framework or module at the moment.

@mandarini mandarini self-assigned this Oct 10, 2023
@mandarini mandarini requested review from a team as code owners October 10, 2023 13:31
@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 12, 2023 2:04pm

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly copy 🍝 issues and one point around globs, otherwise LGTM

@mandarini
Copy link
Member Author

Fixed!

@mandarini mandarini requested a review from JamesHenry October 12, 2023 13:59
@mandarini mandarini force-pushed the feat/nuxt-storybook-config branch from f9edc94 to b0b7b67 Compare October 12, 2023 13:59
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mandarini mandarini merged commit cbeed02 into nrwl:master Oct 12, 2023
2 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants