Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): rename linter to eslint #19515

Merged
merged 11 commits into from
Oct 16, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Oct 9, 2023

TODO

  • Rename project and move linter to legacy
  • Fix imports
  • Add migration for executor
  • Add migration for imports
  • Unit test migration
  • Ensure passing unit tests
  • Ensure passing dependency-checks
  • Ensure passing e2e tests
  • Ensure docs are in sync
  • Add info to rename guideline
  • Add redirects to documentation

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Oct 9, 2023
@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2023 11:55am

@meeroslav meeroslav requested review from a team and JamesHenry as code owners October 10, 2023 21:19
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Angular.

I've a question around the migration.

I see one has been added to the eslint folder to rename imports from linter to eslint.

But if people haven't got the new @nx/eslint package installed, how is this migration expected to run?

Shouldn't it be in a different package?

@meeroslav
Copy link
Contributor Author

@Coly010, that's a very good question.

The @nx/linter package (which is in packages-legacy/linter-nx) and which users will have installed, has dependency to @nx/eslint and migrations pointing to @nx/eslint/migrations.json. So by updating @nx/linter via migration you will trigger the migrations from @nx/eslint and replace dependency in the root package.json.

@meeroslav meeroslav force-pushed the rename-linter-to-eslint branch 3 times, most recently from 301b641 to a36ab02 Compare October 13, 2023 14:27
@meeroslav meeroslav force-pushed the rename-linter-to-eslint branch from d98090c to 65c7a03 Compare October 16, 2023 09:03
@meeroslav meeroslav removed the request for review from leosvelperez October 16, 2023 10:37
@meeroslav meeroslav force-pushed the rename-linter-to-eslint branch from 65c7a03 to 3edf9b2 Compare October 16, 2023 11:55
@FrozenPandaz FrozenPandaz merged commit 0bc6933 into nrwl:master Oct 16, 2023
2 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants