fix(linter): fix linter standalone patterns in Js and Next #19508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 890ebc1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
mandarini
approved these changes
Oct 9, 2023
meeroslav
commented
Oct 9, 2023
| @@ -52,8 +52,11 @@ export function mapLintPattern( | |||
| extension: string, | |||
| rootProject?: boolean | |||
| ) { | |||
| const infix = rootProject ? 'src/' : ''; | |||
| return `${projectRoot}/${infix}**/*.${extension}`; | |||
| if (rootProject && (projectRoot === '.' || projectRoot === '')) { | |||
There was a problem hiding this comment.
In case of E2E projects generated alongside the standalone project, the rootProject would be still true, but project root would point to some e2e-ish folder
JamesHenry
approved these changes
Oct 9, 2023
meeroslav
force-pushed
the
fix-linter-standalone-logic
branch
from
a834978 to
52029a2
Compare
meeroslav
force-pushed
the
fix-linter-standalone-logic
branch
from
52029a2 to
890ebc1
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our packages are missing the logic to properly handle standalone apps linter config.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #