Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): enforce multiword component name #19507

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Oct 9, 2023

Make sure component names for Vue are multiword (https://vuejs.org/style-guide/rules-essential.html#use-multi-word-component-names).

So, the rule is the following:

  • If component is not in a custom directory, prefix it with App if it's an app, prefix it with the lib's name if it's a lib
  • If component is in a custom directory, the name should be prepended with the directory: foo/bar/hello.vue --> FooBarHello

@meeroslav @juristr

@mandarini mandarini requested a review from a team as a code owner October 9, 2023 13:50
@mandarini mandarini requested a review from ndcunningham October 9, 2023 13:50
@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2023 8:16am

@mandarini mandarini self-assigned this Oct 9, 2023
@mandarini mandarini requested a review from meeroslav October 10, 2023 08:05
@mandarini mandarini force-pushed the fix/vue-multiname-component branch from e53862a to 8b14938 Compare October 10, 2023 08:05
@mandarini mandarini force-pushed the fix/vue-multiname-component branch from 8b14938 to 2b635e5 Compare October 10, 2023 08:15
@mandarini mandarini merged commit eabe0f6 into nrwl:master Oct 10, 2023
2 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants